Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to work in Rails console #306

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Update example to work in Rails console #306

merged 2 commits into from
Sep 28, 2018

Conversation

RogerPodacter
Copy link
Contributor

Fixes

Checklist

  • [ x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ x] I have read the [Contribution Guide] and my PR follows them.
  • [ x] I updated my branch with the master branch.
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have added necessary documentation about the functionality in the appropriate .md file
  • [ x] I have added in line documentation to the code I modified

Short description of what this PR does:

Because Mail is used by Rails the "hello world" example doesn't work in the Rails console out of the box. This change fixes that and is also consistent with the existing reference to SendGrid::API which is also strictly speaking unnecessary if one is including this module in a class.

Perhaps there is another way to handle this but my view FWIW is that it's supremely important that simplest example work in the Rails console with no changes.

Because `Mail` is used by Rails the "hello world" example doesn't work in the Rails console out of the box. This change fixes that and is also consistent with the existing reference to `SendGrid::API` which is also strictly speaking unnecessary if one is including this module in a class.

Perhaps there is another way to handle this but my view FWIW is that it's supremely important that simplest example work in the Rails console with no changes.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 9, 2018
@SendGridDX
Copy link

SendGridDX commented Sep 9, 2018

CLA assistant check
All committers have signed the CLA.

README.md Outdated Show resolved Hide resolved
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Sep 28, 2018
@thinkingserious thinkingserious merged commit 7cf058f into sendgrid:master Sep 28, 2018
@thinkingserious
Copy link
Contributor

Hello @RogerPodacter,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@RogerPodacter
Copy link
Contributor Author

RogerPodacter commented Sep 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants