Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use latest SendGrid HTTP Client #405

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

adamnoto
Copy link
Contributor

@adamnoto adamnoto commented Jan 23, 2020

Fixes

Use latest HTTP client so that we can pass in http options.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Closes #405

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 23, 2020
We will auto-increment this. Thanks!
@thinkingserious thinkingserious merged commit daec094 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @saveav,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @saveav,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@adamnoto
Copy link
Contributor Author

@thinkingserious Thank you for your kindness.
Really appreciate : )

@gareth gareth mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants