Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check some repo files #53

Merged
merged 4 commits into from Nov 22, 2017
Merged

Check some repo files #53

merged 4 commits into from Nov 22, 2017

Conversation

gabrielclima
Copy link
Contributor

@gabrielclima gabrielclima commented Oct 29, 2017

Fixes #47

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Create test to check some repo files

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@gabrielclima
Copy link
Contributor Author

Missing files:

  • docker/Docker
  • docker/docker-compose.yml
  • .env_sample
  • .codeclimate.yml
  • LICENSE.md
  • USAGE.md
  • USE_CASES.md

image

Travis CI log : travis-ci.org/sendgrid/smtpapi-go/jobs/294561406

@thinkingserious thinkingserious added the difficulty: medium fix is medium in difficulty label Nov 9, 2017
@mbernier
Copy link

Updated the file to have Dockerfile instead of "Docker" and "License.txt" instead of .md -- these are my fault from the instructions.

@mbernier mbernier merged commit 18a11fc into sendgrid:master Nov 22, 2017
@thinkingserious
Copy link
Contributor

Hello @gabrielclima,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
4 participants