Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .codeclimate.yml and update test/__init__.py #63

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

geomars
Copy link
Contributor

@geomars geomars commented Nov 1, 2017

What does this PR do?

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add .codeclimate.yml
  • Modified test/__init__.py to "facilitate" the travis build job.

Note:
Please update or uncomment several lines in test/__init__.py after the necessary files fulfilled by other Pull Request(PR).

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@geomars geomars changed the title Add .codeclimate.yml and edit test/__init__.py Add .codeclimate.yml and update test/__init__.py Nov 1, 2017
@thinkingserious
Copy link
Contributor

@geomars

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Feb 27, 2018
@thinkingserious
Copy link
Contributor

Hello @geomars,

Could you please resolve the merge conflicts? Thank you!

With Best Regards,

Elmer

@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@thinkingserious thinkingserious changed the title Add .codeclimate.yml and update test/__init__.py chore: Add .codeclimate.yml and update test/__init__.py Nov 19, 2020
@thinkingserious thinkingserious merged commit 588431c into sendgrid:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants