Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added Announcement #93

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

krischoi07
Copy link

Added copy to Announcements. Fixes #92

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Added copy to Announcements. Fixes #92
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #93 into krischoi07-patch-1 will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           krischoi07-patch-1      #93      +/-   ##
======================================================
- Coverage               99.45%   99.32%   -0.13%     
======================================================
  Files                       2        2              
  Lines                     182      149      -33     
======================================================
- Hits                      181      148      -33     
  Misses                      1        1
Impacted Files Coverage Δ
smtpapi/__init__.py 98.71% <0%> (-0.3%) ⬇️
test/__init__.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2affcb...80502df. Read the comment docs.

@thinkingserious thinkingserious merged commit a3fee2f into krischoi07-patch-1 Nov 2, 2018
@thinkingserious
Copy link
Contributor

Hello @krischoi07,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the krischoi07-patch-2 branch January 15, 2020 15:26
@eshanholtz eshanholtz changed the title Added Announcement docs: Added Announcement Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants