Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Conformance To Style Standards With RuboCop & TravisCI #71

Merged

Conversation

alanunruh
Copy link

Fixes #68

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

  • Edited rubocop.yml so that developers may run rubocop in the CLI.
  • Edited rubocop to kickoff with TravisCI.
  • Code edits reflect styleguide changes suggested by rubocop.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 5, 2018

CLA assistant check
All committers have signed the CLA.

@alanunruh alanunruh force-pushed the conformance-to-style-standards branch 2 times, most recently from e19c200 to 7c36ca9 Compare October 8, 2018 18:11
@sendgrid sendgrid deleted a comment from SendGridDX Oct 13, 2018
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest type: twilio enhancement feature request on Twilio's roadmap labels Oct 13, 2018
@thinkingserious
Copy link

Hello @alanunruh,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link

Hello @alanunruh,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@alanunruh
Copy link
Author

alanunruh commented Oct 25, 2018

Hey @thinkingserious! Thanks for letting me help and resolve some issues!

I was reviewing the requirements for 5 points needed for the swag and it looks like one of the options is to contribute two (2) ‘difficulty: medium’ issues. I completed this PR and sendgrid/sendgrid-nodejs#774 and the leaderboard is only saying I have 3 points. No biggie, but just want to point that out if you have some auto calculations doing the leaderboard.

Thanks again for letting me contribute to SendGrid and thanks for all you do with the community! Happy to help in anyway I can.

@thinkingserious
Copy link

Hello @alanunruh,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@childish-sambino childish-sambino changed the title Conformance To Style Standards With RuboCop & TravisCI chore: Conformance To Style Standards With RuboCop & TravisCI Sep 1, 2020
Copy link

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@childish-sambino childish-sambino merged commit 2cae1b5 into sendgrid:main Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
4 participants