We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug If no url is provided when creating a session, the dom object within a Browser class does not get initialized.
dom
Browser
To Reproduce POST to /session/ with the following capabilities:
POST
/session/
{ "capabilities": { "firstMatch": [ { "browserName": "pluma", "plm:plumaOptions": { "runScripts": false } } ] } }
Describe the results you received: this.dom is undefined.
this.dom
Describe the results you expected: this.dom to be set to a default jsdom object.
Additional context Suspected cause is in Browser.ts:
Browser.ts
this.dom = await new JSDOM(' ', { resources: config.resourceLoader, runScripts: config.runScripts, beforeParse: config.beforeParse, pretendToBeVisual: true, cookieJar: config.jar });
await on a non-promise may be preventing the value from being set.
await
The text was updated successfully, but these errors were encountered:
poftadeh
Successfully merging a pull request may close this issue.
Describe the bug
If no url is provided when creating a session, the
dom
object within aBrowser
class does not get initialized.To Reproduce
POST
to/session/
with the following capabilities:Describe the results you received:
this.dom
is undefined.Describe the results you expected:
this.dom
to be set to a default jsdom object.Additional context
Suspected cause is in
Browser.ts
:await
on a non-promise may be preventing the value from being set.The text was updated successfully, but these errors were encountered: