Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples #79

Closed
wants to merge 6 commits into from
Closed

Examples #79

wants to merge 6 commits into from

Conversation

eeswr
Copy link
Contributor

@eeswr eeswr commented Sep 7, 2016

No description provided.

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling 464358d on eeswr:examples into 551e401 on senecajs:master.

@mihaidma
Copy link
Contributor

mihaidma commented Sep 7, 2016

could you please emphasize the line that it depends on basic and entity plugins?
other than that LGTM

@@ -0,0 +1,30 @@
var seneca = require('seneca')()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihaidma @eeswr This should be in docs/examples/basic.js

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling 4113851 on eeswr:examples into 551e401 on senecajs:master.

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling d828e7c on eeswr:examples into 551e401 on senecajs:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.539% when pulling d828e7c on eeswr:examples into 551e401 on senecajs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.539% when pulling d828e7c on eeswr:examples into 551e401 on senecajs:master.

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling d828e7c on eeswr:examples into 551e401 on senecajs:master.

@mihaidma
Copy link
Contributor

mihaidma commented Sep 8, 2016

Parameter names need rename as Dean pointed out.
A few more arrows can be added in code.
"var" could be replaced with "let"

seneca.ready((msg, done) => {
seneca.act({role: 'user', cmd: 'register', name: "Flann O'Brien", email: 'nincompoop@deselby.com', password: 'blackair'},
(msg, done) => {
if (msg) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it's err, reply not msg, done for seneca.acts

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling eeda223 on eeswr:examples into 551e401 on senecajs:master.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 84.539% when pulling fb35071 on eeswr:examples into 551e401 on senecajs:master.

@rjrodger
Copy link
Collaborator

Detailed examples now provided by seneca-msg-test unit tests

@rjrodger rjrodger closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants