better order semantics for plugin lifecycle

senecajs · May 18, 2020 · 97e895b · 97e895b
1 parent d26612c
commit 97e895b
Show file tree

Hide file tree

Showing 14 changed files with 3,559 additions and 2,969 deletions.
diff --git a/lib/api.js b/lib/api.js
@@ -651,7 +651,7 @@ exports.client = function (callpoint) {
     // TODO: review - this feels like a hack
     // perhaps we should instantiate a virtual plugin to represent the client?
     // ... but is this necessary at all?
-    var task_res = self.order.plugin.task.delegate({
+    var task_res = self.order.plugin.task.delegate.exec({
       ctx: {
         seneca: self
       },

diff --git a/lib/errors.js b/lib/errors.js
@@ -145,6 +145,10 @@ module.exports = {
   action_timeout:
     '<%=legacy_string%>Action <%=pattern%> timed out. Timeout was: <%=timeout%> (start: <%=start%>, end: <%=end%>. Message was: <%=message%>.',
 
+  use_no_args:
+  'The seneca.use method needs at least one argument to define a plugin.',
+
+
   // Legacy error message codes
 
   act_invalid_args:

diff --git a/lib/use.js b/lib/use.js
diff --git a/lib/use.js.map b/lib/use.js.map