Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: 'root' is deprecated, use 'global' #566

Closed
tswaters opened this issue Oct 1, 2016 · 6 comments
Closed

DeprecationWarning: 'root' is deprecated, use 'global' #566

tswaters opened this issue Oct 1, 2016 · 6 comments
Assignees
Labels

Comments

@tswaters
Copy link
Member

tswaters commented Oct 1, 2016

Started seeing this logged to the console not too long ago. Finally decided to add a trace and found:

(node:11504) DeprecationWarning: 'root' is deprecated, use 'global'
    at default_log_modifier (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1555:39)
    at Seneca.log_modifier (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1548:5)
    at Seneca.prepare_log_data [as log] (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1529:9)
    at Seneca.log_modifier (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1549:9)
    at Function.prepare_log_data [as debug] (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1529:9)
    at Seneca.api_add [as add] (D:\Code\seneca-tests\node_modules\seneca\seneca.js:663:16)
    at make_seneca (D:\Code\seneca-tests\node_modules\seneca\seneca.js:1369:8)
    at init (D:\Code\seneca-tests\node_modules\seneca\seneca.js:193:16)
    at Context.before (D:\Code\seneca-tests\test\query.test.js:15:10)
    at callFnAsync (D:\Code\seneca-tests\node_modules\mocha\lib\runnable.js:362:21)
    at Hook.Runnable.run (D:\Code\seneca-tests\node_modules\mocha\lib\runnable.js:314:7)
    at next (D:\Code\seneca-tests\node_modules\mocha\lib\runner.js:303:10)
    at Immediate.<anonymous> (D:\Code\seneca-tests\node_modules\mocha\lib\runner.js:333:5)
    at runCallback (timers.js:574:20)
    at tryOnImmediate (timers.js:554:5)
    at processImmediate [as _immediateCallback] (timers.js:533:5)

Looks like 0a584ea moved default_log_modifier to outside make_senca and as a result root no longer points at the right thing - it points at global (for now) where id is not defined.

@jorisroling
Copy link

Is this project dead? It seems that this bug, even though the cause is found, does not get resolved. Anyone?

@AntSworD
Copy link

AntSworD commented Mar 9, 2017

When fix?

@tobiasmuecksch
Copy link

I'm having the same issue

@StarpTech
Copy link
Contributor

StarpTech commented Mar 13, 2017

@jorisroling @tobiasmuecksch @AntSworD Before to talk about why nobody response to this issue I'm going to link to my project which is the result of this and more issues in seneca it has a very similiar API https://github.com/hemerajs/hemera My intention is not to advertise my project its opensource but I cant see anymore people who runs into issues and nobody cares about it.

@xavierbabu
Copy link

I am having the same issue

@rjrodger
Copy link
Collaborator

Oh yeah - this is a bad one - fix will be in 3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants