Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log param parsing #533

Merged
merged 7 commits into from
Sep 12, 2016
Merged

log param parsing #533

merged 7 commits into from
Sep 12, 2016

Conversation

mihaidma
Copy link
Contributor

@mihaidma mihaidma commented Sep 9, 2016

No description provided.

@dgonzalez
Copy link
Member

LGTM

@coveralls
Copy link

coveralls commented Sep 9, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 87.088% when pulling 5353eb8 on logparams into 499214f on master.

@coveralls
Copy link

coveralls commented Sep 9, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 86.978% when pulling 4511c60 on logparams into 499214f on master.

mcdonnelldean
mcdonnelldean reviewed Sep 9, 2016
View reviewed changes
lib/legacy.js
@@ -51,3 +52,16 @@ exports.fail = function make_legacy_fail (so) {
return err
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move this into optioneer rather than legacy

@coveralls
Copy link

coveralls commented Sep 11, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 87.029% when pulling 456c138 on logparams into 499214f on master.

@mihaidma mihaidma changed the title [WIP] log param parsing log param parsing Sep 12, 2016
@coveralls
Copy link

coveralls commented Sep 12, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 87.029% when pulling ab9bc39 on logparams into 499214f on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 87.029% when pulling ab9bc39 on logparams into 499214f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 87.029% when pulling ab9bc39 on logparams into 499214f on master.

@mcdonnelldean mcdonnelldean merged commit 4b96d79 into master Sep 12, 2016
@mcdonnelldean mcdonnelldean deleted the logparams branch September 12, 2016 09:54
@ebarahona ebarahona mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mihaidma @dgonzalez @coveralls @mcdonnelldean