Improved project API #184
Merged
Improved project API #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jone could you review this one? |
|
yeah 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) bugfix if
default-directoryis "~/"This resulted in an endless loop. We now expand the path to git rid of this edge-case.
2.)
(cabbage-project-p)checks if a project is foundThis is a simple function to check if cabbage can detect a project or not. It must be used as a guard to prevent calls into the project API when no root can be found.
3.)
(cabbage-project-expand-path)builds relative project paths.This function is similar to Emacs
expand-pathwith the difference that it builds relative paths to the current(cabbage-project-root). Note that this function throws an error when no(cabbage-project-root)can be found.