Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rvmrc line ending after gemset. #14

Merged
merged 1 commit into from Aug 29, 2011

Conversation

mpasternacki
Copy link
Contributor

Example rvmrc that was failing for me and was fixed by this regexp change:

rvm_archflags="-arch x86_64"
rvm 1.8.7@nginx --create
export rvm_trust_rvmrcs_flag=1

Problem was with the "--create" parameter, that was parsed as part of gemset name

@mpasternacki
Copy link
Contributor Author

I see that's a common point of mistakes; maybe it can be refactored using (split-string-and-unquote)?
http://stackoverflow.com/questions/5911202/elisp-equivalent-of-python-shlex-split

@senny
Copy link
Owner

senny commented Aug 29, 2011

was this .rvmrc generated? Or did you create it yourself? I think the regexp would ignore flags standing before the ruby@gemset definition but if it was generated I think it makes sense to adopt this case also. I just thought normally you put the flags in front of the arguments.

@mpasternacki
Copy link
Contributor Author

No idea, actually. I found it in the repository of project I have joined long after the file was created. I think it was generated, and then edited.

Anyway, there should be no spaces in gemset names, so I believe the regexp change here is safe.

BTW, thanks for rvm.el - it's really great!

senny added a commit that referenced this pull request Aug 29, 2011
Enable rvmrc line ending after gemset.
@senny senny merged commit 9d64f49 into senny:master Aug 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants