Although rvm-configuration-file-name was configured, rvm--rvmrc-locate was not using it. #26

Merged
merged 1 commit into from Jul 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

gaizka commented Jul 14, 2012

My .rvmrc is a shell script, pretty complex (depending on $HOSTNAME), so it cannot be parsed by rvm.el.

I created .rvmrc.el with just one line, and customized rvm-configuration-file-name to ".rvmrc.el".

I expected rvm--rvmrc-locate to find this file, but it was always using ".rvmrc".

This should fix it.

Sorry about not providing any tests, but there are no tests for this behaviour and I am not so fluent testing emacs modules to be able to test it.

@gaizka gaizka Really use rvm-configuration-file-name, it was being ignored
Although rvm-configuration-file-name was configured, rvm--rvmrc-locate
was not using it.
cc671df
Owner

senny commented Jul 14, 2012

@gaizka thanks, this makes perfect sense ;). merged.

@senny senny added a commit that referenced this pull request Jul 14, 2012

@senny senny Merge pull request #26 from gaizka/master
Although rvm-configuration-file-name was configured, rvm--rvmrc-locate was not using it.
49b9463

@senny senny merged commit 49b9463 into senny:master Jul 14, 2012

Contributor

gaizka commented Jul 14, 2012

You are welcome.

Thank YOU for rvm.el, it's really useful!!!

-- Gaizka

El día 14/07/12 07:01 -0700, Yves Senn escribió:

@gaizka thanks, this makes perfect sense ;). merged.


Reply to this email directly or view it on GitHub:
#26 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment