Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Although rvm-configuration-file-name was configured, rvm--rvmrc-locate was not using it. #26

Merged
merged 1 commit into from

2 participants

Gaizka Yves Senn
Gaizka

My .rvmrc is a shell script, pretty complex (depending on $HOSTNAME), so it cannot be parsed by rvm.el.

I created .rvmrc.el with just one line, and customized rvm-configuration-file-name to ".rvmrc.el".

I expected rvm--rvmrc-locate to find this file, but it was always using ".rvmrc".

This should fix it.

Sorry about not providing any tests, but there are no tests for this behaviour and I am not so fluent testing emacs modules to be able to test it.

Gaizka gaizka Really use rvm-configuration-file-name, it was being ignored
Although rvm-configuration-file-name was configured, rvm--rvmrc-locate
was not using it.
cc671df
Yves Senn
Owner

@gaizka thanks, this makes perfect sense ;). merged.

Yves Senn senny merged commit 49b9463 into from
Gaizka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 14, 2012
  1. Gaizka

    Really use rvm-configuration-file-name, it was being ignored

    gaizka authored
    Although rvm-configuration-file-name was configured, rvm--rvmrc-locate
    was not using it.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  rvm.el
2  rvm.el
View
@@ -294,7 +294,7 @@ If no .rvmrc file is found, the default ruby is used insted."
((equal (expand-file-name path) (expand-file-name "~")) nil)
((equal (expand-file-name path) "/") nil)
((member rvm-configuration-file-name (directory-files path))
- (concat (expand-file-name path) "/.rvmrc"))
+ (concat (expand-file-name path) "/" rvm-configuration-file-name))
(t (rvm--rvmrc-locate (concat (file-name-as-directory path) "..")))))
(defun rvm--rvmrc-read-version (path-to-rvmrc)
Something went wrong with that request. Please try again.