Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the backend code of the function scan() to improve efficiency. #100

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

learningMalanya
Copy link
Contributor

Modified the source code for the function scan() for improving efficiency:

  • Modified scan() and scan_perms_lite(), such that single-trait scan ("Null" assumption) will now be performed through vectorized operations in scan_perms_lite(), not by scan_null() anymore.
  • No change to the functions' API.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.86%. Comparing base (b78d3ad) to head (bd5eef3).

Files Patch % Lines
src/scan.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #100      +/-   ##
==========================================
- Coverage   77.08%   76.86%   -0.22%     
==========================================
  Files          12       12              
  Lines         733      722      -11     
==========================================
- Hits          565      555      -10     
+ Misses        168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GregFa GregFa merged commit d666790 into senresearch:dev Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants