Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete="off" to wifi credential inputs #300

Conversation

ubergesundheit
Copy link
Member

Possible fix for #295

@mpfeil
Copy link
Member

mpfeil commented Mar 26, 2019

I tried it and it is not working in Chrome (73.0.3683.86 (Offizieller Build) (64-Bit)) on Windows (10.0.17134 Build 17134).
autocomplete.

I also tried autocomplete="off" on the wifi credentials fields in the editing section and it has no effect. Found different approches but none was working.

Does autocomplete="off" has any effect on your OS?

@ubergesundheit
Copy link
Member Author

oh you're right, I wrote the change without testing from memory. Didn't know Chrome is such a sucker for ignoring autocomplete="off"

@noerw
Copy link
Member

noerw commented Mar 26, 2019

did you try giving it a distinct name attribute? and I heard adding hidden user/password fields to the form diables autocomplete on the visible fields. everything else is difficult as password managers ignore the autocomplete attribute

@mpfeil
Copy link
Member

mpfeil commented Mar 26, 2019

Haven`t tried distinct name attributes.
Hidden user/password fields are ignored by Chrome.

I added something like the following to the form:

<input type="text" style="display:none;">
<input type="password" style="display:none;">

Maybe you can give it a try.

@mpfeil mpfeil deleted the fix-295-disable-autocomplete-for-wifi-credentials branch September 14, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants