Add missing Metrics types #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmackay
commented
Jul 18, 2023
| @@ -97,7 +99,7 @@ export class Table<Schema extends OneSchema = any> { | |||
| getKeys(): Promise<OneIndex> | |||
| getModel<T>( | |||
| name: T extends ModelNames<Schema> ? T : ModelNames<Schema>, | |||
| options?: {nothrow: ?boolean} | |||
| options?: {nothrow?: boolean} | |||
There was a problem hiding this comment.
I think this was also covered in #488
There was a problem hiding this comment.
oh yeah looks like it was. Either works. The 488 PR doesn't make nothrow optional but i can too if needed
|
I think we've applied part of this. So this now has conflicts. Sorry. |
rjmackay
force-pushed
the
fix/metrics-ts
branch
from
ff56b0b
to
07fc3eb
Compare
|
@mobsense Just updated to resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
profileto OneParams type