Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DOM dumping #25

Closed
leonjza opened this issue Oct 1, 2019 · 2 comments
Closed

Add DOM dumping #25

leonjza opened this issue Oct 1, 2019 · 2 comments
Labels
enhancement

Comments

@leonjza
Copy link
Member

leonjza commented Oct 1, 2019

This can be added with the -dump-dom Chrome flag: https://developers.google.com/web/updates/2017/04/headless-chrome#printing_the_dom
@424242424
Copy link

is this issue up for grabs?

@leonjza
Copy link
Member Author

leonjza commented Oct 12, 2019

Absolutely. I just added it so that I don't forget, but PR's welcome!

My current thinking would be to add a new DumpURLDom method next to ScreenshotURL, extracting some of the duplicated code we would have out of the latter. Dumping the DOM should also maybe not be the default, so adding it as a flag would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leonjza @424242424