Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong way to parse Socks5 protocol #26

Open
EddieIvan01 opened this issue Mar 21, 2020 · 1 comment
Open

Wrong way to parse Socks5 protocol #26

EddieIvan01 opened this issue Mar 21, 2020 · 1 comment

Comments

@EddieIvan01
Copy link

In parseSocks5 function:

nmethods, methods = (sock.recv(1), sock.recv(1))

The methods field's length is variable. In some socks5 client, an error will be throwed. Such as curl #9

Should write like this:

nmethods = sock.recv(1)
sock.recv(ord(nmethods))

It seems like no one has been maintaining this repo for a long time, I think my pr will not be handled. So if anyone is going to rewrite this repo, remember to fix it

@L-codes
Copy link

L-codes commented Oct 9, 2020

Thanks for reminding, Neo-reGeorg fixes the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants