Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to update the MAC vendor lookup listings #6

Closed
maximcherny opened this issue Jul 26, 2014 · 2 comments
Closed

Provide the ability to update the MAC vendor lookup listings #6

maximcherny opened this issue Jul 26, 2014 · 2 comments

Comments

@maximcherny
Copy link
Contributor

A quick comparison against the most recent Wirehsark OUI lookup file reveals the potential to add > 1000 additional entries to the mac_vendor.txt lookup file.

https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob_plain;f=manuf;hb=HEAD

While the origin of the mac_vendor.txt is not known to me, I assume it is based on a similar source (e.g. Wirehsark manuf file, IEEE OUI file or another derivative).

Using the Wirehsark manuf file is suggested as the basis as it incorporates data from multiple source and provides the short / long vendor names, as expected by the existing implementation.

The following features could be useful:

  1. Manual refresh on demand
  2. Optionally, automatic refresh as part of the WiFi plugin init
  3. Optionally x2, the ability to retrospectively lookup vendors for devices previously marked as "Unknown"

This should minimise the potential shortcomings around being able to recognise vendors for recently manufactured devices.

@glennzw
Copy link
Contributor

glennzw commented Jul 29, 2014

Hi there,

Brilliant, thanks for doing this. Over the weekend at avery busy location I had a few thousand "unknown" devices - so it's about time I update that file. I created the mac_vendor.txt from the Wireshark list, but almost a year ago.

Also, great idea on the auto-repopulation. Added to ToDo.txt.

Thanks for the feedback,
G

@maximcherny
Copy link
Contributor Author

No worries, thanks for merging. Also, the number of unknown devices may in part be related to the absence of FCS check in scapy, as some mangled MACs and SSIDs come through every now and then.

If the auto-repopulation is a go, I might get another request in to add this as a cmd argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants