Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overfill factor and distortion correction #369

Closed
YxingC opened this issue Jul 13, 2018 · 2 comments
Closed

Overfill factor and distortion correction #369

YxingC opened this issue Jul 13, 2018 · 2 comments

Comments

@YxingC
Copy link

YxingC commented Jul 13, 2018

When overfill and distance scale not equal to 1, it might have some problem in current implementation.
For example, if overfill=1.25 and distance scale = 2 and COP=(0.5,0.5), then origin four corners of uv will times overfill first, then map into D space(distance scale). Overfill factor make uv become (-0.125, -0.125), (1.125, -0.125), (-0.125, 1.125), (1.125, 1.125). After map into D space, everything got wrong. It doesn't consider that overfill will make uv not keep in range 0 - 1.

@russell-taylor
Copy link
Contributor

The relationship among these values and how they are supposed to behave is described in some detail in an upcoming book chapter at https://www.reliasolve.com/wp-content/uploads/2018/05/VR_Concepts_Illustrated_Using_OSVR.pdf which hopefully clarifies the interdependence among these parameters. See the "Overfill and Oversampling" section for how the math is handled when overfill is set larger than 1.

If your concern is theoretical, then the above reference should clarify it. If the problem is that you are seeing unexpected rendering behavior, please describe "everything got wrong" more specifically so I can try to help debug.

@YxingC
Copy link
Author

YxingC commented Jul 14, 2018

Thanks for your replied and info you gave. I think that I understand concept of overfill. I gave the wrong value in config file, which cause that error. I'm sorry for taking your time.

@YxingC YxingC closed this as completed Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants