Skip to content
This repository has been archived by the owner on Sep 14, 2018. It is now read-only.

Commit

Permalink
Revert "-"
Browse files Browse the repository at this point in the history
This reverts commit 7d202a2.
  • Loading branch information
marc.weistroff committed Apr 11, 2012
1 parent 7d202a2 commit e4d895f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -13,7 +13,7 @@
],
"require": {
"php": ">=5.3.2",
"kriswallsmith/buzz": "dev-master"
"kriswallsmith/buzz": "0.5"
},
"target-dir": "Sensio/Bundle/BuzzBundle",
"autoload": {
Expand Down

5 comments on commit e4d895f

@ClementGautier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not >=0.5 ?

@marcw
Copy link
Contributor

@marcw marcw commented on e4d895f Apr 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof ?

@stof
Copy link

@stof stof commented on e4d895f Apr 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is generally a bad idea to use an unbound constraint. It forbids you to tag a release (as this release will not be able to be changed if a BC break occur in the future). However, forcing a precise version is probably too restrictive.

@marcw
Copy link
Contributor

@marcw marcw commented on e4d895f Apr 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof What is the solution then ? Writing ">= 0.5" ? Working with another branch of the bundle which allow "dev-master" ?

@stof
Copy link

@stof stof commented on e4d895f Apr 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, >=0.5 is probably the easiest. But take care to add an upper bound before creating a tag for the bundle

Please sign in to comment.