This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
fix visibility of setFormat method #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks OK to me |
|
It looks OK to me. I'll wait a bit more beore merging it in case someone wants to rais questions or concerns. |
|
Thank you @Razmo. |
fabpot
added a commit
that referenced
this pull request
Nov 10, 2015
This PR was merged into the 3.0.x-dev branch. Discussion ---------- fix visibility of setFormat method This PR change the visibility of setFormat method. This change is necessary if we need to extend the DoctrineCrudGenerator class. If we redefine the generate method in our new class, we have an error because we call the setFormat method who is private. The first solution is to change the visibility of setFormat method (that what i propose in this PR). The second solution is to duplicate the method in our new class (bad idea if we don't need to redefine it) Commits ------- abb059f fix visibility of setFormat method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the visibility of setFormat method.
This change is necessary if we need to extend the DoctrineCrudGenerator class.
If we redefine the generate method in our new class, we have an error because we call the setFormat method who is private.
The first solution is to change the visibility of setFormat method (that what i propose in this PR). The second solution is to duplicate the method in our new class (bad idea if we don't need to redefine it)