This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Fix PSR-2 line length recommendations #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @eliecharra. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
This PR was merged into the 3.0.x-dev branch. Discussion ---------- Fix PSR-2 line length recommendations Extension template is generating an inline phpdoc `@link` which exceed PSR-2 line lenght recommendation. http://www.php-fig.org/psr/psr-2/#1-overview > There MUST NOT be a hard limit on line length; the soft limit MUST be 120 characters; lines SHOULD be 80 characters or less. `@link` anotation is enough imho, maybe previous text could be removed to get under recommended line length. Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no Commits ------- d83ed9f Fix PSR2 line length recommendations
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension template is generating an inline phpdoc
@linkwhich exceed PSR-2 line lenght recommendation.http://www.php-fig.org/psr/psr-2/#1-overview
@linkanotation is enough imho, maybe previous text could be removed to get under recommended line length.