This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Implement quoted services references for Symfony 3 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think by using Gherkin is the easiest to describe the scope of this pull request: Given the symfony instance is 2.8 or upper If the service has a dependency on another service Then the service argument should be quoted in " And no deprecation notice will be raised
gabiudrescu
changed the title
|
I think we should simply always removed single quotes instead of double quotes (in double quotes you need to be careful to not use escape sequences, for example). |
|
@xabbuh not a bad idea. I kinda followed the example in place right now, but if you or anyone else finds this a good idea, it can be modified. |
|
Thank you @gabiudrescu. |
fabpot
added a commit
that referenced
this pull request
Jan 5, 2016
…rescu) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Implement quoted services references for Symfony 3 I think by using Gherkin is the easiest to describe the scope of this pull request: Given the symfony instance is 2.8 or upper If the service has a dependency on another service Then the service argument should be quoted in " And no deprecation notice will be raised If the generator is currently used to create a bundle on a 2.8 / 3 instance of Symfony, the services.yml file will have examples of services without quotes. E.g: ``` services: # game.example: # class: GameBundle\Example # arguments: [@service_id, "plain_value", %parameter%] ``` To avoid potential troubles, I thought the example should be as I have modified it with my pull request. Commits ------- b5cb5c7 Implement quoted services references
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think by using Gherkin is the easiest to describe the scope of this pull request:
Given the symfony instance is 2.8 or upper
If the service has a dependency on another service
Then the service argument should be quoted in "
And no deprecation notice will be raised
If the generator is currently used to create a bundle on a 2.8 / 3 instance of Symfony, the services.yml file will have examples of services without quotes.
E.g:
To avoid potential troubles, I thought the example should be as I have modified it with my pull request.