This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Replace getMock calls with getMockBuilder()->getMock() calls in tests #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see in the Travis build this fails on older PHPUnit versions. If you want to avoid the deprecated |
|
Thanks @xabbuh I just noticed myself and will update the PR so it still works with older phpunit versions. |
hairmare
force-pushed
the
feature/phpunit-bumpage
branch
from
b423f10
to
ba8e2fe
Compare
hairmare
changed the title
hairmare
changed the title
hairmare
force-pushed
the
feature/phpunit-bumpage
branch
from
ba8e2fe
to
f6141b6
Compare
|
I updated this PR so it works with PHPUnit <5 as well as PHPUnit >= 5.4. |
|
@xabbuh can this be merged? |
|
@narcoticfresh Sorry, I am not a maintainer of this bundle. But the changes so far look good to me. |
|
@hairmare Looks good to me as well. Small nitpicking: can you move the whole expression on one line for each call? |
The upgrade to PHPUnit 5.4 wants us to use `getMockBuilder()->getMock()` instead of `getMock()` as per https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-5.4.0#changes. This PR changes the tests so they execute properly using the latest PHPUnit again.
hairmare
force-pushed
the
feature/phpunit-bumpage
branch
from
f6141b6
to
969ca07
Compare
|
@fabpot I addressed the formatting changes and rebased the pull request. Thanks |
|
Thank you @hairmare. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2016
…ls in tests (hairmare) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Replace getMock calls with getMockBuilder()->getMock() calls in tests The upgrade to PHPUnit 5.4 wants us to use `createMock` instead of `getMock` as per [the PHPUnit 5.4 Releasenotes](https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-5.4.0#changes). This PR changes the tests so they execute properly using the latest PHPUnit. Commits ------- 969ca07 Replace getMock calls with getMockBuilder()->getMock() calls in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to PHPUnit 5.4 wants us to use
createMockinstead ofgetMockas per the PHPUnit 5.4 Releasenotes.This PR changes the tests so they execute properly using the latest PHPUnit.