This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Fixed Form 2.7 compatibility in type and crud generation #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
force-pushed
the
fix/form-generator_2_7_compat
branch
from
c701fde
to
bbbdb53
Compare
| @@ -22,7 +22,7 @@ | |||
| if ($form->isSubmitted() && $form->isValid()) { | |||
| $em = $this->getDoctrine()->getManager(); | |||
| $em->remove(${{ entity_singularized }}); | |||
| $em->flush(); | |||
| $em->flush(${{ entity_singularized }}); | |||
There was a problem hiding this comment.
This change looks unrelated 😉
There was a problem hiding this comment.
it's not the only minor optimization hidden around ;)
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Oct 9, 2016
…ahDude) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Fixed Form 2.7 compatibility in type and crud generation Commits ------- bbbdb53 Fixed Form 2.7 compatibility in type and crud generation
HeahDude
added a commit
to HeahDude/SensioGeneratorBundle
that referenced
this pull request
Oct 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.