Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSS prefix being defined early #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support CSS prefix being defined early #16

wants to merge 3 commits into from

Commits on Oct 10, 2019

  1. Support CSS prefix being defined early 

    The CSS prefix that is part of the theme takes precedence over the prefix
supplied to the converter.

Deprecates $prefix parameter from Theme::asCss()

It would be cumbersome to support a dynamic prefix at this late stage of
the rendering.

Tests updated to cover the following combinations.

1. Using the default theme or a supplied theme, with and without its own
   css prefix.
2. Using the default css prefix or a supplied prefix.
3. Using inline styling or CSS.
    Richard Quadling authored and Richard Quadling committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    e467fb8 View commit details
    Browse the repository at this point in the history

  2. c/s and some comments

    Richard Quadling authored and Richard Quadling committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    9bb755b View commit details
    Browse the repository at this point in the history

  3. Additional tests to include all themes and reversed colouring. 

    Unit tests now provide 100% code coverage.
    Richard Quadling authored and Richard Quadling committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    444c15d View commit details
    Browse the repository at this point in the history