Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path and selector from page and element #97

Closed
DonCallisto opened this issue Sep 30, 2017 · 2 comments
Closed

Remove path and selector from page and element #97

DonCallisto opened this issue Sep 30, 2017 · 2 comments

Comments

@DonCallisto
Copy link
Contributor

Hi @jakzal, why are we using a protected property?
Shouldn't be better to declare this an abstract method (as well as selector for elements)?

If this could be an improvement, we can include this for a next major release and introduce a deprecation message to the current one.

What do you think?

@DonCallisto DonCallisto changed the title Remove $path and $selector Remove path and selector from page and element Sep 30, 2017
@jakzal
Copy link
Member

jakzal commented Oct 4, 2017

As I said in #99 (comment) I don't even remember why this is protected. Perhaps I thought people will find it useful to override it, but I didn't want to force them to implement the method as it's actually not required, unless you call open() on a page (not every page is opened directly, in most cases they're returned as a result of method calls on other pages).

Anyway, In the referenced ticket I gave some ideas on how we could improve the current state. I'd appreciate your input.

@DonCallisto
Copy link
Contributor Author

Ok, let's continue in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants