You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I said in #99 (comment) I don't even remember why this is protected. Perhaps I thought people will find it useful to override it, but I didn't want to force them to implement the method as it's actually not required, unless you call open() on a page (not every page is opened directly, in most cases they're returned as a result of method calls on other pages).
Anyway, In the referenced ticket I gave some ideas on how we could improve the current state. I'd appreciate your input.
Hi @jakzal, why are we using a protected property?
Shouldn't be better to declare this an abstract method (as well as
selector
for elements)?If this could be an improvement, we can include this for a next major release and introduce a deprecation message to the current one.
What do you think?
The text was updated successfully, but these errors were encountered: