This repository has been archived by the owner on May 31, 2021. It is now read-only.
Fixed some typos #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Username/Id: `csarrazi/7494d27255d0561157b8` | ||
| * Gist URI: `https://gist.github.com/csarrazi/7494d27255d0561157b8` | ||
| * Gist Id: `565752f13499a3fa17d9` | ||
| * Username/Id: `csarrazi/565752f13499a3fa17d9` |
There was a problem hiding this comment.
You are fast ;) Fixed. Thanks.
|
it would be good to fix the runner to support HHVM properly |
|
and no, allowing failure on HHVM is not the right way |
|
@stof huhu. I don't have HHVM installed on my laptop :( So it's not going to be easy to fix it. More over, it looks like it's a travis issue. Then, IMHO, HHVM support could be added into another PR. |
|
👍 |
|
-1 for the allowed failure. instead, you should fix to use the HHVM-compatible way to build the php executable. See the fix done in SensioDistributionBundle a while ago |
| @@ -8,13 +8,13 @@ You can easily [create a gist](https://gist.github.com) to share a snippet and | |||
| execute it using `melody`. Instead of downloading the file to your computer, | |||
| simply pass the URL to `melody`: | |||
|
|
|||
| $ melody run https://gist.github.com/csarrazi/7494d27255d0561157b8 | |||
| $ melody run https://gist.github.com/lyrixx/565752f13499a3fa17d9 | |||
|
@stof I'm going to merge this one because the HHVM support could and will be added by another PR. Then this PR really have to be merged to avoid angry user and to avoid duplicate effort |
lyrixx
added a commit
that referenced
this pull request
Dec 6, 2014
This PR was merged into the master branch. Discussion ---------- Fixed some typos Commits ------- de2a4ba Fixed some code issue (thanks SensioLabsInsight) e20c1e6 Fixed composer vendor dir detection when the composer binary is outdated 3346502 [Travis] Allow failure with hhvm e49d261 [Travis] Fixed configuration 156d484 Updated vendor 4e284ce Fixed tests dcc2958 [Doc] Fixed wrong doc (old format) c2af15c Fixed bad copy/paste
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.