This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
removed dependency on ext-curl #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
curl-requirement-removal
branch
5 times, most recently
from
189d17e
to
6292137
Compare
|
Another option is to drop cURL support and only keep ping @javiereguiluz @stof |
|
👍 to remove the cURL requirement. In Symfony Installer we recently switched to use In any case, I'd maintain cURL support because the support of |
fabpot
force-pushed
the
curl-requirement-removal
branch
from
6292137
to
e4147ba
Compare
| $this->crawler->setEndPoint($endPoint); | ||
| } | ||
|
|
||
| public function doCheck($lock, $certFile) |
fabpot
force-pushed
the
curl-requirement-removal
branch
from
e4147ba
to
f5b58ae
Compare
|
Comments addressed |
fabpot
force-pushed
the
curl-requirement-removal
branch
from
f5b58ae
to
24ef857
Compare
| throw new RuntimeException(sprintf('The web service failed for an unknown reason (HTTP %s).', $statusCode)); | ||
| } | ||
|
|
||
| curl_close($curl); |
There was a problem hiding this comment.
you could call curl_close($ch) just after getting the status code as none of the code paths after that are using $ch anymore. It would avoid having 3 different places getting it
fabpot
force-pushed
the
curl-requirement-removal
branch
from
24ef857
to
37e2b9c
Compare
fabpot
force-pushed
the
curl-requirement-removal
branch
from
37e2b9c
to
d7e788a
Compare
|
👍 |
fabpot
added a commit
that referenced
this pull request
Aug 3, 2015
This PR was merged into the 2.0-dev branch. Discussion ---------- removed dependency on ext-curl Having a hard dependency on cURL is problematic. For instance, this library is a dep of SensioDistributionBundle, which is also a dep of Symfony Standard Edition. So, it means that we are forcing everyone using Symfony SE to have the PHP cURL extension installed, which is not what we want. So, this PR falls back to using file_get_contents when cURL is not installed. Commits ------- d7e788a removed dependency on ext-curl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a hard dependency on cURL is problematic. For instance, this library is a dep of SensioDistributionBundle, which is also a dep of Symfony Standard Edition. So, it means that we are forcing everyone using Symfony SE to have the PHP cURL extension installed, which is not what we want.
So, this PR falls back to using file_get_contents when cURL is not installed.