Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty array conversion in GenericFunc #130

Merged
merged 3 commits into from Jan 5, 2017

Conversation

nobu-k
Copy link
Member

@nobu-k nobu-k commented Jan 3, 2017

The current version had a problem that passing an empty array to a UDF resulted in receiving nil instead of the empty array.

func F(a data.Array) data.Array {
  return a
}

udf.RegisterGlobalUDF("f", udf.MustConvertGeneric(F))

>>> EVAL f([]);
null

I fixed the root cause and other issues related to nil handling.

@disktnk disktnk self-assigned this Jan 5, 2017
@disktnk
Copy link
Member

disktnk commented Jan 5, 2017

LGTM!

@disktnk disktnk merged commit 484b890 into sensorbee:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants