Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdk: Update 2.5.0->3.0.0 #154

Merged
merged 2 commits into from Aug 22, 2023
Merged

pdk: Update 2.5.0->3.0.0 #154

merged 2 commits into from Aug 22, 2023

Conversation

bastelfreak
Copy link
Contributor

No description provided.

@ju5t
Copy link
Collaborator

ju5t commented Aug 22, 2023

@bastelfreak the new Gemfile seems to break the installation on my machine. I'm unable to install it. The error I'm getting is:

Bundler could not find compatible versions for gem "puppet":
  In Gemfile:
    puppet

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (= 1.48.1)

    rubocop-rspec (= 2.19.0) was resolved to 2.19.0, which depends on
      rubocop (~> 1.33)

Bundler could not find compatible versions for gem "ruby":
  In Gemfile:
    ruby

    pry (~> 0.10) was resolved to 0.14.2, which depends on
      ruby (>= 2.0)

    puppet was resolved to 7.25.0, which depends on
      ruby (>= 2.5.0)

    puppet was resolved to 7.25.0, which depends on
      ruby (>= 2.5.0) universal-darwin-22

    puppet_litmus (~> 1.0) was resolved to 1.1.3, which depends on
      ruby (>= 2.7.0)

    rubocop (= 1.48.1) was resolved to 1.48.1, which depends on
      ruby (>= 2.6.0)

Does it work for you? I've tried Ruby 2.7.8 and 3.2.0 and I'm on MacOS with an M1 chip.

Also, this can probably be removed (sorry, only found out after everything was merged), as support for Ruby < 2.7.0 was dropped.

gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))

@bastelfreak bastelfreak deleted the pdk branch August 22, 2023 13:58
@bastelfreak
Copy link
Contributor Author

Those are the default pdk settings. They are supposed to work on Ruby 2.7 and newer (I'm not a huge pdk fan and usually try to avoid it). The pdk commands works for me, like 'pdk test unit' and 'pdk validate puppet'. Which commands did you run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants