Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Becoming a collaborator/maintainer #17

Closed
majormoses opened this issue Apr 30, 2017 · 7 comments
Closed

Becoming a collaborator/maintainer #17

majormoses opened this issue Apr 30, 2017 · 7 comments

Comments

@majormoses
Copy link
Member

What is the process for becoming a collaborator? I have been contributing where I can via code and review but would like to be able to help with moderating (merging sane requests, releasing, etc) the ever increasing amount of sensu issues.

@mattyjones @portertech

@mattyjones
Copy link
Member

From the code I have seen and the consistency of the pr's I am good with this.

@eheydrick

@sstarcher
Copy link
Member

sstarcher commented May 1, 2017

From what I have seen of @majormoses I'm in support. He has been very active.

@mattyjones
Copy link
Member

good enough for me as well. Invite has been sent as well as added to the team that gives commit-bit. @majormoses

@majormoses
Copy link
Member Author

@mattyjones is there a bot that does our gem releases or do I need to be added individually to the gems in order to release?

@majormoses
Copy link
Member Author

@eheydrick
Copy link
Contributor

@majormoses That's the old process not used anymore. The docs need to be updated but basically the new process is you create a github release and travis runs a gem deploy. I use the hub command: hub release create x.y.z. Other things about releases:

  1. Make sure the CHANGELOG reflects all the changes. The Unreleased link in the CHANGELOG gives you a nice diff.
  2. Make sure the README is updated as necessary.
  3. Follow semver. Breaking changes are a major. Any new checks are a minor. Fixes to existing checks are a patch.
  4. Make sure the gem is actually uploaded to rubygems. It's rare but I've seen times when it doesn't upload for whatever reason.
  5. travis will only deploy if the build is passing so make sure master is building before cutting a release.

@majormoses
Copy link
Member Author

@eheydrick thanks I have created an issue and assigned it to myself for updating the documentation after I have tried it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants