New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metrics multi-chip aware, update changelog #5

Merged
merged 3 commits into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@GhostLyrics
Collaborator

GhostLyrics commented Mar 10, 2017

Pull Request Checklist

Is this in reference to an existing issue? yes, issue #4

General

  • Update Changelog following the conventions laid out on Keep A Changelog

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Example output

kronos.sensors.i350bb-pci-8100.loc1 66.0 1489162933
kronos.sensors.power_meter-acpi-0.power1 894.0 1489162933
kronos.sensors.coretemp-isa-0000.core0 29.0 1489162933
kronos.sensors.coretemp-isa-0000.core1 34.0 1489162933
kronos.sensors.coretemp-isa-0000.core2 31.0 1489162933
kronos.sensors.coretemp-isa-0000.core3 28.0 1489162933
kronos.sensors.coretemp-isa-0000.core4 28.0 1489162933
kronos.sensors.coretemp-isa-0000.core8 27.0 1489162933
kronos.sensors.coretemp-isa-0000.core9 28.0 1489162933
kronos.sensors.coretemp-isa-0000.core10 27.0 1489162933
kronos.sensors.coretemp-isa-0000.core11 27.0 1489162933
kronos.sensors.coretemp-isa-0000.core12 27.0 1489162933
kronos.sensors.coretemp-isa-0001.core0 32.0 1489162933
kronos.sensors.coretemp-isa-0001.core1 34.0 1489162933
kronos.sensors.coretemp-isa-0001.core2 34.0 1489162933
kronos.sensors.coretemp-isa-0001.core3 35.0 1489162933
kronos.sensors.coretemp-isa-0001.core4 35.0 1489162933
kronos.sensors.coretemp-isa-0001.core8 32.0 1489162933
kronos.sensors.coretemp-isa-0001.core9 33.0 1489162933
kronos.sensors.coretemp-isa-0001.core10 36.0 1489162933
kronos.sensors.coretemp-isa-0001.core11 37.0 1489162933
kronos.sensors.coretemp-isa-0001.core12 34.0 1489162933

Known Compatablity Issues

  • I don't know for sure whether all versions support the -A flag. I looked in the Changelog of lm-sensors but could not find any mention when this was introduced, so I assumed it was not a recent change.
  • I don't know about all use cases; I've added collecting the power draw in here, but for people who simply put all of the values into a graph without filtering before, those will wonder why there is one value which is much, much higher than the others.
@GhostLyrics

This comment has been minimized.

Show comment
Hide comment
@GhostLyrics

GhostLyrics Mar 10, 2017

Collaborator

Hold the presses, I missed a metric. Updating now.

Collaborator

GhostLyrics commented Mar 10, 2017

Hold the presses, I missed a metric. Updating now.

@GhostLyrics

This comment has been minimized.

Show comment
Hide comment
@GhostLyrics

GhostLyrics Mar 10, 2017

Collaborator

Sorry for that. Updated :)

Collaborator

GhostLyrics commented Mar 10, 2017

Sorry for that. Updated :)

@GhostLyrics GhostLyrics referenced this pull request Mar 10, 2017

Merged

Rewrite readme to new style doc #6

0 of 8 tasks complete

@eheydrick eheydrick merged commit 1f19e06 into sensu-plugins:master Mar 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eheydrick

This comment has been minimized.

Show comment
Hide comment
@eheydrick

eheydrick Mar 10, 2017

Contributor

👍

Contributor

eheydrick commented Mar 10, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment