Added metrics #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
requested changes
Apr 18, 2018
| if value.is_a? Hash | ||
| print_hash(value, new_path) | ||
| else | ||
| output "#{config[:scheme]}#{new_path}", value unless value.nil? || value.empty? |
There was a problem hiding this comment.
I think we should return false so that people can potentially rescue on it.
| end | ||
| end | ||
|
|
||
| def array_to_naming_hash(array, key_name, only = nil) |
There was a problem hiding this comment.
I think only is a bit ambiguous and should be renamed to something like filter_keys.
majormoses
added
Status: Awaiting Response
Impact: Breaking Change
and removed
Status: Needs Review
labels
|
@majormoses - fixed |
majormoses
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
test
sensu-plugins/community#97
sensu-plugins/community#77