Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some much needed cleanup #60

Merged
merged 1 commit into from Dec 15, 2018
Merged

some much needed cleanup #60

merged 1 commit into from Dec 15, 2018

Conversation

majormoses
Copy link
Member

@majormoses majormoses commented Nov 21, 2018 •
edited

Signed-off-by: Ben Abrams me@benabrams.it

Pull Request Checklist

General

  • Update Changelog following the conventions laid out at here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Addressed CVEs:

Misc Changes:

  • use sensu-plugin 2.x
  • removed support for ruby < 2.3
  • appeased the cops

Known Compatibility Issues

  • use sensu-plugin 2.x
  • removed support for ruby < 2.3

@majormoses
some much needed cleanup
c97b2b3 
Addressed CVEs:
- CVE-2017-8418
- CVE-2017-17042

Breaking Changes:
- use `sensu-plugin` 2.x
- removed support for ruby < 2.3

Misc Changes:
- appeased the cops

Signed-off-by: Ben Abrams <me@benabrams.it>
@majormoses
Copy link
Member Author

majormoses commented Dec 15, 2018 •
edited

Looks like I am forced to self merge without review 😞

@majormoses majormoses merged commit e14be8c into master Dec 15, 2018
@majormoses
Copy link
Member Author

released: https://rubygems.org/gems/sensu-plugins-kubernetes/versions/4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Impact: Breaking Change Type: Enhancement Type: Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@majormoses