Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different defaults for used ram in check-ram.rb #67

Open
sekrett opened this issue Sep 19, 2017 · 3 comments
Open

Different defaults for used ram in check-ram.rb #67

sekrett opened this issue Sep 19, 2017 · 3 comments

Comments

@sekrett
Copy link

sekrett commented Sep 19, 2017

For example it is ok to have 20% of free ram but 40% of used ram is considered critical which is probably wrong.

@majormoses
Copy link
Member

Yes this check has sane defaults when you take them as is, when using --used you will want to adjust your thresholds accordingly. I have not reviewed that code in a while so I am not sure how feasible it is to modify the defaults when an option is changed only if if cli opts were not passed in

This is related to a couple issues/prs so I am linking them for context:

If you can propose a solution I am more than happy to review a PR.

@majormoses majormoses changed the title Different defaults for used ram Different defaults for used ram in check-ram.rb Sep 23, 2017
@sekrett
Copy link
Author

sekrett commented Sep 24, 2017

It think it should be the inverse for --used: 90% for warn and 95% for crit. I'll try to do a PR.

@majormoses
Copy link
Member

Yup, the trick is to only do that when someone has not changed the defaults which is when I originally did I did not realize and it made it impossible to overwrite. We had to fix it so that it always allowed the user full control. If you can think of some way to do that I am all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants