Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded threshold values in check-ram.rb override command line values #46

Closed
jaykumar-jnpr opened this issue Oct 6, 2016 · 0 comments

Comments

@jaykumar-jnpr
Copy link

Following line override warning and critical threshold set when using "-u" or "--used" memory values.

L88 config[:warn] = 90
L89 config[:crit] = 95

If the current memory usage is at 91% and threshold as set as follows, it will not alert as threshold set on command line are overridden by above two lines

/opt/sensu/embedded/bin/ruby check-ram.rb --used -w 80 -c 90

Expected behaviour:

CheckRAM CRITICAL: 91% RAM used

Actual

CheckRAM WARNING: 91% RAM used

majormoses added a commit to majormoses/sensu-plugins-memory-checks that referenced this issue Oct 11, 2016
remove hardcoded values when using `--used`
@majormoses majormoses mentioned this issue Oct 11, 2016
5 tasks
majormoses added a commit to majormoses/sensu-plugins-memory-checks that referenced this issue Oct 14, 2016
- breaking change: remove hardcoded values when using `--used`. (major vertsion bump)
- appease rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant