some cleanaup work #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVES: - https://nvd.nist.gov/vuln/detail/CVE-2017-17042 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418 Breaking Changes: - removing ruby `< 2.3` support Fixes: - backported a fix from the slack handler I made in sensu-plugins/sensu-plugins-slack#62 as I realized it shared the same code. I am thinking going forward it might be nice to have that be part of the `sensu-plugin` class so it could be available to all plugins without having a bunch of shared code. Misc Updates: - appeased the cops Signed-off-by: Ben Abrams <me@benabrams.it>
|
@asachs01 if you would like to review and possibly test this pull request that would be appreciated since you have a setup with teams. |
|
@majormoses I'll give it a test later this morning. |
asachs01
approved these changes
Sep 13, 2018
|
^ pulled from the feature/cleanup branch, and everything appears 👍 . I'd say you're good to push it @majormoses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVES:
Breaking Changes:
< 2.3supportFixes:
unknownsensu-plugins-slack#62 as I realized it shared the same code. I am thinking going forward it might be nice to have that be part of thesensu-pluginclass so it could be available to all plugins without having a bunch of shared code.Misc Updates:
Signed-off-by: Ben Abrams me@benabrams.it
Pull Request Checklist
Yes:
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Address several known security issues and backporting a change made to the slack handler.
Known Compatibility Issues
Breaks compatibility with ruby versions
< 2.3