memory check is done in % instead of KB

[thapakazi]

I have some humble changes here, to address my own issue

[analytically]

This breaks backwards compatibility. Would you be able to add two new options that make the check use % instead instead of replacing the kB ones. Thanks!

[thapakazi]

@analytically sure !!
or for ease, we have have seperate check file like: check-redis-memory-percent.rb so the
What do you say ??

...my applogies didn't think of compatibility. 😲

[analytically]

No, best to keep it in the same file, but using options.

[analytically]

Actually, yes, put it in a separate check file.

[thapakazi]

There is a small issue to adress regarding %, I will try push the changes asap.

P.S: @analytically how do you guys test the plugins, I am doing it with manual process with some hit-and-trial method. Any words of wisdom you want to share ?

[eheydrick]

It would be great if you could add some specs. Beyond that, do a smoke test against a real instance.

[eheydrick]

Any updates on this?

[thapakazi]

@eheydrick kinda occupied, I will try my best push changes this weekend

[thapakazi]

@eheydrick /cc @analytically
Pushed the changes on sperate file as check-redis-memory-percentage.rb and I have reverted the old file.

Here is snapshot results in my notification channel. that check threshold 2% is too clumsy... but i am getting lazy these days..

[envintus]

@eheydrick, @zerOnepal Is this pull request still under consideration to be merged?

[thapakazi]

@envintus i have pushed the changes..

wonder what's taking too long for it to merge...

[eheydrick]

can you add the standard header per http://sensu-plugins.io/docs/developer_guidelines.html#coding-style

[thapakazi]

sure... my bad

[eheydrick]

@zerOnepal can you add the new plugin to the CHANGELOG and README and we'll get this merged.

[thapakazi]

@eheydrick done

[eheydrick]

Thanks @zerOnepal!