Multiple updates #59
Merged
Multiple updates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredledvina
approved these changes
Jul 6, 2018
|
Hmm I will look into this later, not sure why thats bricking from a quick look. This is why we have tests! |
majormoses
force-pushed
the
feature/improve-error-message-when-settings.api-key-does-not-exist
branch
from
cddf5bb
to
87d104c
Compare
majormoses
changed the title
check-stale-results when api config is not present
- improving error message in `check-stale-results` when api config is not present - updating `rubocop` dep and appeasing the cops - updating `yard` dep - updating `sensu-plugin` dep - added slack badge - removed gemnasium badge CVE's addressed: - https://nvd.nist.gov/vuln/detail/CVE-2017-17042 - https://nvd.nist.gov/vuln/detail/CVE-2017-8418 Breaking Changes: - removed ruby `< 2.3` support Signed-off-by: Ben Abrams <me@benabrams.it>
majormoses
force-pushed
the
feature/improve-error-message-when-settings.api-key-does-not-exist
branch
from
87d104c
to
2e83ba6
Compare
|
@jaredledvina I could not figure out why it was complaining until I bumped the min ruby version and switched to the |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Updates:
check-stale-resultswhen api config is not presentrubocopdep and appeasing the copsyarddepsensu-plugindepCVE's addressed:
Breaking Changes:
< 2.3supportSigned-off-by: Ben Abrams me@benabrams.it
Pull Request Checklist
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Help user understand what the error means and how they can fix it.
Known Compatibility Issues