[CVE-2017-8418] - updating rubocop dependency. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
8d2c3f0
to
c64ac48
Compare
amdprophet
reviewed
Feb 27, 2018
bin/metrics-xen.rb
Outdated
|
|
||
| def run | ||
| xen = metrics_hash | ||
| xm = xm_hash | ||
| xencount = xenservers | ||
| i = 0 | ||
| xen.each do |_k, v| | ||
| # TODO: come back and refactor me | ||
| xen.each_value do |_k, v| # rubocop:disable Metrics/BlockLength |
There was a problem hiding this comment.
I think each_value only passes one param (the value of each key) into the block.
There was a problem hiding this comment.
Good catch, was too quick to look at the rubocop correction closely enough. I will get that fixed up.
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
c64ac48
to
97151a9
Compare
|
@amdprophet should be good now, let me know if you spot anything else. |
Breaking Changes: - removed ruby `< 2.1` support Misc: - appeased the cops - fixed bug with single quotes where interpolation is needed - update changelog guidelines link Signed-off-by: Ben Abrams <me@benabrams.it>
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
97151a9
to
cc035f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes:
< 2.1supportMisc:
Signed-off-by: Ben Abrams me@benabrams.it
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Resolve CVE, see parent issue for details
Known Compatibility Issues
Removes ruby
< 2.1support