Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and update sample-app.md #2027

Closed
1 of 5 tasks
hillaryfraley opened this issue Dec 17, 2019 · 11 comments
Closed
1 of 5 tasks

Audit and update sample-app.md #2027

hillaryfraley opened this issue Dec 17, 2019 · 11 comments
Labels
help wanted Need help to resolve hold for now Not working now, but may in the future inbox cleanup Issue identified for inbox cleanup discussion needs discussion Need to discuss and decide how to proceed

Comments

@hillaryfraley
Copy link
Contributor

hillaryfraley commented Dec 17, 2019

This is an issue with:

  • Bug (site functionality or styling)
  • Errata (fix needed for doc content)
  • New content (guide wanted)
  • Update (Add missing or refresh existing content)
  • Enhancement (add new site functionality)

Expected Behavior

In https://docs.sensu.io/sensu-go/latest/getting-started/sample-app/:

  • The step-by-step instructions work with no errors.
  • The instructions are up-to-date with the current Kubernetes API versions and config requirements.

Current Behavior

  • There are gaps in the instructions that result in errors that users may not be able to solve.
  • The instructions have not been updated to reflect current Kubernetes API versions and config requirements.

Possible Solution

Audit the sample app instructions to complete any gaps and update repo files to incorporate Kubernetes changes.

Affected Docs Pages

https://docs.sensu.io/sensu-go/latest/getting-started/sample-app/

Context

I ran into an error at step 3 of the Set Up section when trying to walk through the sample app. Aaron and I worked on the instructions on a Zoom call, and he discovered issues like:

selector:
  matchLabels:
    app: sensu-backend

This sample app has many external dependencies that Sensu cannot control and is difficult to maintain as a docs walkthrough. Would it make more sense to recreate this as a Katacoda scenario? If we decide to maintain it outside the docs, would it be a Developer Advocate-maintained resource?

@hillaryfraley hillaryfraley self-assigned this Dec 17, 2019
@hillaryfraley hillaryfraley added the help wanted Need help to resolve label Dec 17, 2019
@hillaryfraley hillaryfraley added this to Inbox in sensu-docs via automation Dec 17, 2019
@hillaryfraley hillaryfraley moved this from Inbox to To Do in sensu-docs Jan 13, 2020
@hillaryfraley hillaryfraley moved this from To Do to In Progress in sensu-docs Jan 13, 2020
@hillaryfraley hillaryfraley removed the help wanted Need help to resolve label Jan 13, 2020
@hillaryfraley
Copy link
Contributor Author

The http://sensu.local example seems fine because I think it's just a Sensu Backend URL placeholder, but should we update it to follow the placeholder format we've used in other docs (something like http://127.0.0.1:8080)?

I am less sure about the http://webui.sensu.local/signin/ and http://webui.sensu.local/events/ links. Based on our other docs, it seems like http://localhost:3000/signin and http://localhost:3000/events would be more appropriate.

I could not confirm any of this because I could not get past the "3. Deploy kube-state-metrics." step. I get this error:
error: the path "kube-state-metrics/kubernetes" does not exist

Not sure if it's a problem with the doc or something I'm doing wrong.

@hillaryfraley hillaryfraley added the help wanted Need help to resolve label Jan 16, 2020
@asachs01
Copy link
Contributor

@hillaryfraley I can pair with you on this.

@hillaryfraley hillaryfraley changed the title Confirm dashboard links in sample-app.md Audit needed for sample-app.md Jan 23, 2020
@hillaryfraley hillaryfraley added needs discussion Need to discuss and decide how to proceed and removed help wanted Need help to resolve labels Jan 23, 2020
@hillaryfraley hillaryfraley moved this from In Progress to Inbox in sensu-docs Jan 23, 2020
@hillaryfraley hillaryfraley removed their assignment Jan 23, 2020
@hillaryfraley hillaryfraley changed the title Audit needed for sample-app.md Audit and update sample-app.md Jan 23, 2020
@hillaryfraley
Copy link
Contributor Author

hillaryfraley commented Jan 23, 2020

We updated the docs so that they no longer link to sample-app.md (see #2133). Leaving this issue open pending further discussion about final dispensation.

@hillaryfraley
Copy link
Contributor Author

Issues Aaron identified in 1/24/20 retro:

  • Kubernetes extension apis have changed and have been deprecated
  • Kube state metrics have changed how that app is deployed as well
  • Minikube on OSX (maybe even on Windows) is now using hyperkit, which makes use of a different IP range than what Virtualbox uses
  • Number of deployments inside of the sensu-kube-demo repo now contain deprecated references that make setup impossible

@hillaryfraley
Copy link
Contributor Author

Text of issue #2270 from Edgar:

Description

Looks as though a while ago some changes where made to the repo causing our guide to no longer work at step 3. I believe it needs to be updated to kubectl apply -f kube-state-metrics/examples/standard but this needs to be tested.

Category

This is an issue with:

  • errata (error in doc content)
  • new doc (requires a completely new doc)
  • update (add missing or refresh existing content)
  • improvement (improve docs content or format)

Affected pages

https://docs.sensu.io/sensu-go/latest/getting-started/sample-app/#set-up

Expected behavior

Sample app should be deployed.

Current behavior

Folder does not exist in the repo, deployment fails

Corrections needed

App should be located in metrics/examples/standard but not sure if this is the same one as before.

@hillaryfraley hillaryfraley added the help wanted Need help to resolve label Jun 10, 2020
@hillaryfraley
Copy link
Contributor Author

Dev Advocates added to sprint and will take a look to see if they can help: https://sensu.slack.com/archives/CCBBAAZQW/p1591623677174900

@hillaryfraley
Copy link
Contributor Author

See also #2447. When we restore the sample-app.md page in the docs, we should make sure our docs search is picking it up as a result for a sidecar search.

@hillaryfraley hillaryfraley removed this from Inbox in sensu-docs Jul 8, 2021
@hillaryfraley
Copy link
Contributor Author

@hillaryfraley hillaryfraley added the inbox cleanup Issue identified for inbox cleanup discussion label Dec 16, 2021
@hillaryfraley
Copy link
Contributor Author

Added to agenda for 1/13/2022 CR+DA sync

@hillaryfraley
Copy link
Contributor Author

hillaryfraley commented Jan 13, 2022

Discussed in 1/13/22 CR+DA sync meeting. Caleb thinks there will be a replacement for the deprecated repo and we will be able to rebuild this tutorial. Currently on hold pending Sensu Catalogs work.

@hillaryfraley hillaryfraley added the hold for now Not working now, but may in the future label Jan 20, 2022
@asachs01
Copy link
Contributor

asachs01 commented Jun 5, 2023

We've pretty well removed this from the docs. I'm going to close this issue.

@asachs01 asachs01 closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need help to resolve hold for now Not working now, but may in the future inbox cleanup Issue identified for inbox cleanup discussion needs discussion Need to discuss and decide how to proceed
Projects
None yet
Development

No branches or pull requests

2 participants