-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit and update sample-app.md #2027
Comments
The I am less sure about the I could not confirm any of this because I could not get past the "3. Deploy kube-state-metrics." step. I get this error: Not sure if it's a problem with the doc or something I'm doing wrong. |
@hillaryfraley I can pair with you on this. |
We updated the docs so that they no longer link to sample-app.md (see #2133). Leaving this issue open pending further discussion about final dispensation. |
Issues Aaron identified in 1/24/20 retro:
|
Text of issue #2270 from Edgar:DescriptionLooks as though a while ago some changes where made to the repo causing our guide to no longer work at step 3. I believe it needs to be updated to CategoryThis is an issue with:
Affected pageshttps://docs.sensu.io/sensu-go/latest/getting-started/sample-app/#set-up Expected behaviorSample app should be deployed. Current behaviorFolder does not exist in the repo, deployment fails Corrections neededApp should be located in |
Dev Advocates added to sprint and will take a look to see if they can help: https://sensu.slack.com/archives/CCBBAAZQW/p1591623677174900 |
See also #2447. When we restore the sample-app.md page in the docs, we should make sure our docs search is picking it up as a result for a |
Update from Jef: https://sumologic.slack.com/archives/C0250SG6Y03/p1626802296029100 |
Added to agenda for 1/13/2022 CR+DA sync |
Discussed in 1/13/22 CR+DA sync meeting. Caleb thinks there will be a replacement for the deprecated repo and we will be able to rebuild this tutorial. Currently on hold pending Sensu Catalogs work. |
We've pretty well removed this from the docs. I'm going to close this issue. |
This is an issue with:
Expected Behavior
In https://docs.sensu.io/sensu-go/latest/getting-started/sample-app/:
Current Behavior
Possible Solution
Audit the sample app instructions to complete any gaps and update repo files to incorporate Kubernetes changes.
Affected Docs Pages
https://docs.sensu.io/sensu-go/latest/getting-started/sample-app/
Context
I ran into an error at step 3 of the Set Up section when trying to walk through the sample app. Aaron and I worked on the instructions on a Zoom call, and he discovered issues like:
kubectl apply -f kube-state-metrics/examples/standard
virtualbox
specified as the driver (see https://kubernetes.io/docs/tasks/tools/install-minikube/#confirm-installation). If you use hyperkit (which seems to be the minikube default), the IP addresses will be different. The instructions should make this clearer.sensuctl asset add
throughout.kubectl apply
commands for yaml files, the yaml files need to be updated to use the correctapi_version
(apps/v1) and to addselector
in the spec. For example:This sample app has many external dependencies that Sensu cannot control and is difficult to maintain as a docs walkthrough. Would it make more sense to recreate this as a Katacoda scenario? If we decide to maintain it outside the docs, would it be a Developer Advocate-maintained resource?
The text was updated successfully, but these errors were encountered: