-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include example template + check hook output #31
Conversation
Still needs some format changes. How about this?
However, this does bring to light one issue. When using HTML, the formatting of the hook output (or any multi-line string) won't be properly formatted. Here's an example using the template above. |
@cwjohnston can I get a 👍 on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some manifest -> definition changes.
Also, it seems like this handler has some command line flags that should be covered in a usage
section.
Co-Authored-By: Cameron Johnston <cameron@rootdown.net>
Co-Authored-By: Cameron Johnston <cameron@rootdown.net>
Co-Authored-By: Cameron Johnston <cameron@rootdown.net>
Co-Authored-By: Cameron Johnston <cameron@rootdown.net>
@cwjohnston can you take a gander again plz? |
This solves for #27 and #30 by providing a workaround in the form of a template + check hook output that can be put into the template body until the plugin is refactored so that hook output and templates aren't mutually exclusive.