Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler extensions don't respect stashed checks #2

Closed
gffhcks opened this issue Nov 11, 2014 · 1 comment
Closed

Handler extensions don't respect stashed checks #2

gffhcks opened this issue Nov 11, 2014 · 1 comment

Comments

@gffhcks
Copy link

gffhcks commented Nov 11, 2014

I'm using the Flapjack Handler extension from sensu-community-plugins. When I implemented it, I expected the extension to work like regular plugin extensions do - if you apply a Stash to a check, it ignores that check until the stash expires. But from what I can tell, extensions ignore stashes completely.

I could modify the extension to check stashes in the same way that the sensu-plugin code does. But that approach requires you to duplicate the code for every handler extension that you want to actually respect stashes. Would there be any way to implement this directly in extensions instead, possibly with a config toggle allowing it to be turned on or off?

@cwjohnston
Copy link
Contributor

@gffhcks thanks for opening this issue, now almost two years ago!

We've recently released Sensu 0.26 with built-in silencing, described here in our reference doc. This silencing implementation works with extensions as well as plugins, making silencing a real first-class citizen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants