Move LastOK onto Check instead of Event

Signed-off-by: Zach Bintliff <zbintliff@gmail.com>

CHANGELOG.md

@@ -21,7 +21,6 @@ set when importing legacy settings.
 - Add event metrics type, implementing the Sensu Metrics Format.
 - Added non-functional selections for resolving and silencing to web ui
 - Add LastOk to event type. This will be updated to reflect the last timestamp of a succesful event
-- Add LastOK to event type. This will be updated to reflect the last timestamp of a succesful event
 
 ### Changed
 - Refactor Check data structure to not depend on CheckConfig. This is a breaking

backend/eventd/eventd.go

@@ -158,7 +158,6 @@ func (e *Eventd) handleMessage(msg interface{}) error {
 		}
 
 		event.Check.MergeWith(prevEvent.Check)
-		event.LastOK = prevEvent.LastOK
 	}
 
 	// Calculate percent state change for this check's history

backend/eventd/eventd_test.go

@@ -69,7 +69,7 @@ func TestEventHandling(t *testing.T) {
 
 	// Make sure the event has been marked with the proper state
 	assert.Equal(t, types.EventPassingState, event.Check.State)
-	assert.Equal(t, badEvent.Timestamp, event.LastOK)
+	assert.Equal(t, event.Timestamp, event.Check.LastOK)
 }
 
 func TestEventMonitor(t *testing.T) {

backend/eventd/flapping.go

@@ -25,7 +25,7 @@ func state(event *types.Event) {
 		event.Check.State = types.EventFlappingState
 	} else if event.Check.Status == 0 {
 		event.Check.State = types.EventPassingState
-		event.LastOK = event.Timestamp
+		event.Check.LastOK = event.Timestamp
 	} else {
 		event.Check.State = types.EventFailingState
 	}

types/check.go

@@ -231,6 +231,7 @@ func (c *Check) MergeWith(chk *Check) {
 	}
 
 	c.History = history
+	c.LastOK = chk.LastOK
 }
 
 // FixtureCheckRequest returns a fixture for a CheckRequest object.

types/check.proto

@@ -200,6 +200,9 @@ message Check {
   // check's history
   uint32 total_state_change = 29;
 
+  // LastOK displays last time this check was ok; if event status is 0 this is set to timestamp
+  int64 last_ok = 30 [(gogoproto.customname) = "LastOK"];
+
   // ExtendedAttributes store serialized arbitrary JSON-encoded data
   bytes ExtendedAttributes = 99 [(gogoproto.jsontag) = "-"];
 }