Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keepalive check missing issued & executed timestamps #1440

Closed
portertech opened this issue May 3, 2018 · 2 comments
Closed

Keepalive check missing issued & executed timestamps #1440

portertech opened this issue May 3, 2018 · 2 comments
Assignees
Labels

Comments

@portertech
Copy link
Contributor

The keepalive check is missing issued & executed timestamps. Keepalive checks are a special case, as they are created and maintained by the Backend.

Using the latest master Docker image:

screen shot 2018-05-03 at 12 10 16 pm

@portertech portertech added the bug label May 3, 2018
@portertech
Copy link
Contributor Author

Related but not applied to Backend keepalive checks a58c538

@mercul3s
Copy link
Contributor

mercul3s commented May 3, 2018

Ah, that's probably also affecting the keepalive check history as well. This is what a keepalive check looks like as json output:

"check": {
    "check_hooks": null,
    "duration": 0,
    "environment": "default",
    "handlers": [
      "keepalive"
    ],
    "high_flap_threshold": 0,
    "history": [
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {},
      {}
    ],
    "interval": 120,
    "issued": 0,
    "last_ok": 1525379486,
    "low_flap_threshold": 0,
    "metric_handlers": null,
    "name": "keepalive",
    "occurrences": 1,
    "occurrences_watermark": 1,
    "organization": "default",
    "proxy_entity_id": "",
    "publish": false,
    "round_robin": false,
    "runtime_assets": null,
    "state": "passing",
    "status": 0,
    "stdin": false,
    "subdue": null,
    "subscriptions": [],
    "timeout": 0,
    "total_state_change": 0,
    "total_state-change": 0
  }

@amdprophet amdprophet self-assigned this Aug 2, 2018
@palourde palourde closed this as completed Aug 3, 2018
@palourde palourde reopened this Aug 3, 2018
amdprophet added a commit that referenced this issue Aug 3, 2018
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>

## What is this change?

Sets the `Issued` and `History` attributes on a keepalive event.

## Why is this change necessary?

Fixes #1440.
Fixes #1731.

## Does your change need a Changelog entry?

Yes.

## Do you need clarification on anything?

Nope.

## Were there any complications while making this change?

Nope.

## Have you reviewed and updated the documentation for this change? Is new documentation required?

No documentation updates required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants