Add LastOk to Event (#1034)

CHANGELOG.md

@@ -20,6 +20,7 @@ set when importing legacy settings.
 - Configured and enabled etcd autocompaction.
 - Add event metrics type, implementing the Sensu Metrics Format.
 - Added non-functional selections for resolving and silencing to web ui
+- Add LastOk to check type. This will be updated to reflect the last timestamp of a succesful check 
 
 ### Changed
 - Refactor Check data structure to not depend on CheckConfig. This is a breaking

README.md

@@ -32,7 +32,7 @@ Otherwise, see the **for non-C++ users** [instructions here.](https://github.com
 
 ### Quick Start
 
-Once you make a change to any `*.proto` file within the **types** package, you will need regenerate the associated `*.pb.go` file. To do so, simply run the [genproto.sh](https://github.com/sensu/sensu-go/blob/master/scripts/genproto.sh) script, which will install all required dependencies and launch the code generation.
+Once you make a change to any `*.proto` file within the **types** package, you will need to regenerate the associated `*.pb.go` file. To do so, simply run the [genproto.sh](https://github.com/sensu/sensu-go/blob/master/scripts/genproto.sh) script, which will install all required dependencies and launch the code generation (be sure to run the below `./build.sh deps` first though).
 
 ## Dependencies
 

backend/eventd/eventd_test.go

@@ -69,6 +69,7 @@ func TestEventHandling(t *testing.T) {
 
 	// Make sure the event has been marked with the proper state
 	assert.Equal(t, types.EventPassingState, event.Check.State)
+	assert.Equal(t, event.Timestamp, event.Check.LastOK)
 }
 
 func TestEventMonitor(t *testing.T) {

backend/eventd/flapping.go

@@ -25,6 +25,7 @@ func state(event *types.Event) {
 		event.Check.State = types.EventFlappingState
 	} else if event.Check.Status == 0 {
 		event.Check.State = types.EventPassingState
+		event.Check.LastOK = event.Timestamp
 	} else {
 		event.Check.State = types.EventFailingState
 	}

types/check.go

@@ -231,6 +231,7 @@ func (c *Check) MergeWith(chk *Check) {
 	}
 
 	c.History = history
+	c.LastOK = chk.LastOK
 }
 
 // FixtureCheckRequest returns a fixture for a CheckRequest object.

types/check.proto

@@ -200,6 +200,9 @@ message Check {
   // check's history
   uint32 total_state_change = 29;
 
+  // LastOK displays last time this check was ok; if event status is 0 this is set to timestamp
+  int64 last_ok = 30 [(gogoproto.customname) = "LastOK"];
+
   // ExtendedAttributes store serialized arbitrary JSON-encoded data
   bytes ExtendedAttributes = 99 [(gogoproto.jsontag) = "-"];
 }