Agent configuration cleanup #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bonjour Mathieu :) Thank you very much for submitting this PR, it's really appreciated. Concerning the default value for |
- Moves all default values for the agent CLI into const in agent.go - Uses theses const values in the agent CLI - Modify NewConfig to return an empty Config - Creates a new FixtureConfig function to create a new Config for tests - Updates the tests to use FixtureConfig Signed-off-by: mcorbin <corbin.math@gmail.com>
mcorbin
force-pushed
the
agent/configuration-cleanup
branch
from
d5bb9bf
to
334e3a4
Compare
|
Bonjour Simon ;) I updated the PR. It's now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mcorbin corbin.math@gmail.com
What is this change?
I tried to fix #392. the goal was to have the agent default configuration in one place.
I created some
constvariables for the agent default configuration, and used them instart.go. I also created a newFixtureConfigfunction for tests.Why is this change necessary?
The agent default configuration was in two distinct places, in the
NewConfigfunction insensu-go/agent/agent.goand in the CLI default insensu-go/agent/cmd/start.go.Does your change need a Changelog entry?
I added one.
Do you need clarification on anything?
I'm not sure about the default
flagCacheDirvalue. It'spath.SystemCacheDir("sensu-agent")(so/var/cache/sensu/sensu-agent) instart.gobut it was"/var/cache/sensu"inNewConfig.Were there any complications while making this change?
I don't know Golang well ;)